Bring back getDescription export
#1165
Conversation
|
OK looks like there are some typing things to work through, I will come back to it tomorrow. |
|
You should also have this exported from index.js if you expect to use it in a dependent library, otherwise it might be too easy to regress again! We assume exports used between files are used purely internally. It might be helpful to audit for other deep require uses as well to avoid future breakage |
|
@leebyron happy to make that modification for sure, we definitely have 3-4 others we are using. Didn't realize that was the intention with the internal exports! Any idea what the argument type should be here? I would have thought |
|
Try out |
We were using this in graphql-tools with graphql@0.11, would be nice to get it exported again! Update buildASTSchema.js Fix formatting Add types for getDescription Export getDescription from the root
|
OK looks like it's all good now, thanks for the suggestions! |
|
Nice. I'll likely have a point release out today or tomorrow that will include this. Also, apparently this is your first commit to GraphQL.js. Congrats! 🎉 |
That is SO SURPRISING. I'll look into contributing more! I guess I spent more time on GraphQL.org that I misattributed. |
|
I'm also using |
|
@leebyron hi, when can you update package? |
We were using this in graphql-tools with graphql@0.11, would be nice to get it exported again!