-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
language/printer not handle line break for comment inside args #1285
Comments
Thanks for the report. This is definitely a bug in VCS's syntax highlighter, however I agree that the output of |
leebyron
added a commit
that referenced
this issue
Mar 29, 2018
Descriptions were not separated on their own lines, which made for technically parseable but hard to read output. Fixes #1285
leebyron
added a commit
that referenced
this issue
Mar 29, 2018
Descriptions were not separated on their own lines, which made for technically parseable but hard to read output. Fixes #1285
leebyron
added a commit
that referenced
this issue
Mar 29, 2018
Descriptions were not separated on their own lines, which made for technically parseable but hard to read output. Fixes #1285
This was referenced Jun 16, 2018
This was referenced Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi guys,
I report you a bug find with the graph.cool team and about Prisma cli and the generation of the SDL schema.
You can see the initial discussion here: https://github.com/graphcool/prisma/issues/2047
The bug is about highlighting in VSC (maybe a bug about the GraphQL Syntax plugin), but in fact I see a difference between the function
printSchema
andprint
.The problem is just about a missing line break before a comment when it's about args for a "function"
If
printSchema
was fixed previous month (here #1205), theprint
function not handle correctly comments for function's args:graphql-js/src/language/printer.js
Lines 131 to 138 in 3493edd
I think it just need so verification so see if the
args
begins or contains some comments to add a line break.Thanks for your help!
The text was updated successfully, but these errors were encountered: