Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findBreakingChanges does not support extended types #2055

Closed
erangakm opened this issue Jul 26, 2019 · 4 comments
Closed

findBreakingChanges does not support extended types #2055

erangakm opened this issue Jul 26, 2019 · 4 comments

Comments

@erangakm
Copy link

Old type:

extend type Report {
  displayName: String!
}

type Report {
  id: Int!
}

New type:

extend type Report {
  displayName: String
}

type Report {
  id: Int!
}

Removing the nullability on the extended type doesn't trigger a breaking change at the moment. Would be great if this is supported :)

@IvanGoncharov
Copy link
Member

@erangakm What function you use to build your schemas?
Is it buildSchema?
Problem is that buidlSchema simply ignores extensions node as discussed in #922.

@erangakm
Copy link
Author

erangakm commented Jul 28, 2019

@IvanGoncharov I'm using makeExecutableSchema

Unlike the problem outlined in the issue you linked, I can see that the type I extended in the schema working correctly. It's just I can't see any breaking changes to it when I use findBreakingChanges

@IvanGoncharov
Copy link
Member

@erangakm Thanks for additional info I will try to take a look.
You can help a lot if you create a small repo that reproduces this issue.

@yaacovCR
Copy link
Contributor

Closed by #2248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants