-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single field subscriptions validator has conflicts with the spec #2715
Labels
Comments
nikis05
changed the title
Single field subscriptions rule has conflicts with the spec
Single field subscriptions validator has conflicts with the spec
Jul 22, 2020
I would like to look into this issue and work on a fix. @IvanGoncharov can I please get assigned to solve this bug? |
I noticed this too; whoever fixes this, please can you ping me on #2861 as I'll need to incorporate the fix into that PR. |
I may have resolved this bug as part of #2861 |
This was referenced Dec 5, 2020
@benjie can this be closed? |
I believe so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The rule: https://github.com/graphql/graphql-js/blob/master/src/validation/rules/OverlappingFieldsCanBeMergedRule.js
The spec states that subscriptions should have a single root field. Current implementation only checks that there is one selection on selection set of the subscription, not taking fragments into account. If a single selection is a fragment spread or an inline fragment (with multiple fields) this rule will wrongfully pass.
The text was updated successfully, but these errors were encountered: