Skip to content

Latest commit

 

History

History
108 lines (77 loc) · 4.88 KB

FullSchemas.md

File metadata and controls

108 lines (77 loc) · 4.88 KB

RFC: Full Schemas

Proposed by: Martin Bonnin - Apollo

Problem statement

In its current form the GraphQL specification contains language about the presence of built-in definitions in SDL schemas:

  • scalars MUST be absent from SDL (here)
  • directives SHOULD be absent(here)
  • introspection types are not mentioned in the spec (See here for a pull request to address this)

This is made for brevity and correctness reasons. When the SDL document is fed to a GraphQL implementation like graphql-js, there is no need to add the built-in definitions as the implementation will add them. Adding built-in definitions in the input schema could also be confusing: what definition is used? The one from the input schema or the one from the implementation? It makes sense overall to omit built-in definitions from SDL documents that are used by GraphQL implementations.

But the absence of built-in definitions can make it impossible for client tools to validate an operation without knowing more details about what is supported by the server.

For an example, the below query is valid if the server uses the latest draft but is not valid if the server uses the Oct2021 specification:

{
  __schema {
    types {
      name
      inputFields {
        name
        # isDeprecated is only present in latest versions of the specification
        isDeprecated
        deprecationReason
      }
    }
  }
}

In general, it would be nice to have a SDL format that would be a full representation of the server schema, even if it means it is more verbose.

This proposal is about allowing SDL documents that contain all the information required for tooling to validate any operation, later denominated as "full schema".

Proposal 1: relax SDL requirements

An easy solution is to relax the SDL requirements and leave it up to tools to determine how they react to missing or existing built-in definitions.

A GraphQL implementation like graphql-js could decide to throw an error if it is fed with a definition that it itself provides. It could also decide to react on what is in the input schema. For an example, @include/@skip could be left unsupported by not adding them in the input schema.

A GraphQL client like apollo-kotlin could decide to throw an error if the introspection types are missing. Or add options to specify manually what built-in definitions to use for validation.

Proposal 2: be explicit about "full schemas" vs current, regular "schemas"

Another solution is to introduce "full schemas" in addition to the existing SDL schemas. A "full schema" is a schema that also contains the built-in definitions added by the implementation.

This proposal is more opinionated but also less flexible than proposal 1. It's either "regular schema" or "full schema" but an implementation could not decide to use some of the input definitions while still adding its own on top of them.

Questions

Q: Why not always use introspection results?

Introspection is the tool that was designed for clients to consume schemas, so it could be argued that client should use that. However:

  1. Some servers have introspection disabled making it hard for clients to get an introspection schema
  2. In general, SDL is a much more readable and concise representation than the introspection JSON, making it more suited for workflows where the file is read by humans (IDEs, codegen, etc...)
  3. SDL schemas can represent applied directives, which introspection can't (see #300). Tools could use that information to provide a better developer experience, add functionality, etc...

Q: Wouldn't that make inconsistent SDL documents containing unused definitions?

There is a (unwritten?) rule that SDL definitions must all be used (with an exception for built-in scalars and directive definitions). Hence, adding the introspection types to SDL would result in this schema being valid:

type Query {
    random: String
}

type __Schema { ... }
type __Type { ... }
enum __TypeKind { ... }
type __Field { ... }
type __InputValue { ... }
type __EnumValue { ... }
type __Directive { ... }
enum __DirectiveLocation { ... }

Although technically nothing would use the __Schema type. For this, we would need to add the __schema meta-field:

type Query {
    random: String
    __schema: __Schema
}

But then doing so for typename would become very noisy:

type Foo {
    # add __typename here
    __typename: String!
}
type Bar {
    # and here as well
    __typename: String!
}
union SomeUnion = Foo | Bar {
    # Technically unions have __typename, should we do this? 
    __typename: String!
}