Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2021-01-07] Review "RFC: Assert subscription field is not introspection. #2861" #583

Closed
benjie opened this issue Jan 18, 2021 · 1 comment
Closed

[2021-01-07] Review "RFC: Assert subscription field is not introspection. #2861" #583

benjie opened this issue Jan 18, 2021 · 1 comment
Assignees
@IvanGoncharov
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Jan 18, 2021

Ivan has some concerns about the complexity of the JS implementation, but agrees with the spec changes.
ACTION - Ivan: thorough review of the PR

PR to review: graphql/graphql-js#2861

Note: Action Item issues are reviewed and closed during Working Group
meetings.
@benjie benjie mentioned this issue Jan 18, 2021
Closed
@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Apr 8, 2021
@benjie
Copy link
Member Author

benjie commented Apr 8, 2021

Ivan has approved this PR (but not yet merged it, pending potential refactoring).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanGoncharov IvanGoncharov

Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leebyron @benjie @IvanGoncharov