Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coinbase transaction for account based currencies #13

Open
Tommel71 opened this issue Jan 8, 2024 · 0 comments
Open

Add coinbase transaction for account based currencies #13

Tommel71 opened this issue Jan 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Tommel71
Copy link
Member

Tommel71 commented Jan 8, 2024

Right now, coinbase transactions are not considered for balance calculations. This is because Null values in fromAddress are ignored and callTypeFilter is applied before calculating credits. A fix could be implemented in

graphsense-spark/src/main/scala/org/graphsense/account/eth/Transformation.scala

Line 131 in a9e980c

val credits = traces

@Tommel71 Tommel71 added the enhancement New feature or request label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tommel71