Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loftusa patch 3 #1054

Closed
wants to merge 2 commits into from
Closed

Loftusa patch 3 #1054

wants to merge 2 commits into from

Conversation

loftusa
Copy link
Collaborator

@loftusa loftusa commented Dec 11, 2023

@bdpedigo proposed fix to #1035. Kinda janky, but it bought my imports down to 2.35 seconds:

Screenshot 2023-12-11 at 3 04 37 PM

@loftusa loftusa requested a review from bdpedigo December 11, 2023 21:04
@bdpedigo
Copy link
Collaborator

linear_sum_transport gets called many many times during an optimization so (if i understand what this will do correctly) that import would also happen over and over again if that code is called - not sure that is viable. would ideally get at something closer to the root cause of this (for instance, why does POT need to even import tensorflow here...)

@bdpedigo
Copy link
Collaborator

closing since there hasnt been action on this but happy to revisit if there's interest

@bdpedigo bdpedigo closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants