-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use poetry
build system, update Python version to ^3.8 to include 3.12+
#1067
Conversation
@darthtrevino just checking if you're all done making changes? |
also, wondering if you can describe what the new release process with this system would be. not familiar with |
Yep, no more source changes in this PR. So the poetry-dynamic-version plugin will use So the normal release flow is like this:
You'll probably want to ensure that the publication step will work on prerelease builds before cutting a public release. |
You can test this process out locally if you've got the plugin installed - create a new tag on a branch (e.g. v4.0.0) then run |
thanks @darthtrevino ! |
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
This overall goal of this PR is to support Python 3.12+. I felt that this was not a safe thing to change without a deterministic dependency management system, so I included Poetry. The makefile scripts have been moved inside
pyproject.toml
, in addition to the content found in setup.py, setup.cfg, requirements.txt, etc.. More can be done here, but this is a first stepp.Any other comments?
We'll need to address the publication step and setting a version there. There are tools and plugins we can leverage on the poetry side, but we should also be using the Pypi Trusted Publisher configuration to avoid having to use twine to manually upload the final artifacts.