Heatmap updates #750

loftusa · 2021-04-04T19:47:45Z

adds section in heatmap tutorial for hierarchy labels
adds ticklabels functionality in heatmap function that seaborn has
small bug fix and error checking changes

netlify · 2021-04-04T19:47:50Z

❌ Deploy Preview for graspologic failed.

🔨 Explore the source changes: 50dcb7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/graspologic/deploys/6124f6021d885900084b9af3

graspologic/plot/plot.py

bdpedigo · 2021-04-05T21:36:54Z

why make this a wrapper, as opposed to an option?

loftusa · 2021-04-05T23:01:29Z

why make this a wrapper, as opposed to an option?

I thought it was a little more clunky as an option, since turning it into an option implies that you can't use the center or cmap params anymore. I guess I could make the cmap parameter only take sets of two colors in the binary case?

I can make it an option if you'd prefer!

pytest.ini

Fix a few bugs

bdpedigo · 2021-05-12T16:14:11Z

graspologic/plot/plot.py

+    colors : list-like or np.ndarray
+        A list of exactly two colors to use for the heatmap.
+
+    colorbar_ticklabels : list-like


if I don't want this, can it be turned off (like it can be for heatmap)

looks like yes, can you add somewhere in docs?

bdpedigo · 2021-08-23T20:32:58Z

@loftusa what's the status of this PR, left a few comments above but wondering if we should push in or close?

loftusa · 2021-08-24T12:50:11Z

@loftusa what's the status of this PR, left a few comments above but wondering if we should push in or close?

I think probably binary_heatmap is unnecessary / overengineering, but the additions I made to the tutorial + the bug fixes are still useful. I'll just take that part out, keep the useful stuff, and re-request review.

bdpedigo · 2021-09-15T17:18:01Z

tests/test_plot.py

@@ -12,6 +12,7 @@
    heatmap,
    pairplot,
    pairplot_with_gmm,
+    binary_heatmap,


dont need this?

agreed, fixed

loftusa · 2021-10-28T21:54:49Z

@bdpedigo status on this? I saw approved, but I'm not authorized to merge

bdpedigo · 2021-10-29T12:55:09Z

tests still werent passing

loftusa · 2021-10-29T15:33:35Z

tests still werent passing

looks like they broke yesterday with 44f372e. One sec

bdpedigo · 2021-12-07T18:32:13Z

@loftusa any interest in getting this merged? if not will close for the time being

loftusa · 2021-12-07T18:38:47Z

@loftusa any interest in getting this merged? if not will close for the time being

Yeah - the doc-building error was weird and I wasn't sure how to fix, then other stuff took priority...

TypeError: 'generator' object is not reversible

Exception occurred:
  File "/home/docs/checkouts/readthedocs.org/user_builds/graspologic/envs/750/lib/python3.8/site-packages/sphinx/util/nodes.py", line 94, in apply_source_workaround
    for classifier in reversed(node.parent.traverse(nodes.classifier)):
TypeError: 'generator' object is not reversible

bdpedigo · 2021-12-07T20:17:36Z

I dont see any current doc errors, just a format check?

bdpedigo · 2021-12-13T14:52:42Z

I dont see any current doc errors, just a format check?

bump @loftusa

bdpedigo · 2021-12-13T14:52:55Z

oops didnt mean to hit close

into heatmap-updates

loftusa · 2022-01-18T20:50:38Z

AttributeError: type object 'gensim._matutils.array' has no attribute '__reduce_cython__'

what the heck is this

bdpedigo · 2022-06-27T15:55:22Z

seeing if the issue fixed itself 🤞

* Added Python 3.11 (#1039) * add python 3.11 * fix numba dep warning * add release note entry (#1040) * Updated heatmap (#750) * test pytest ini * add binary_heatmap, updates to tutorial notebook * test plotting * re-add pytest.ini * Update plot.py Fix a few bugs * add new tests * Update setup.cfg * remove binary_heatmap * mpl version req back to normal * remove binary_heatmap import * black * formatting fix --------- Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com> * Fixed bugs in type specifications from Numpy 1.25 release (#1047) * attempted fix for matrix type erroring * fix spec of csr_array * add a random seed * remove isspmatrix * fix a type check * black * Added option for more efficient graph matching matrix operations (#1046) * more efficient graph matching matrix operations * fix formatting * remove an unused import (unrelated) * expose fast kwarg to user, docs * run black formatter * add typehint * fix mypy --------- Co-authored-by: bkj <ben@jataware.com> Co-authored-by: bdpedigo <benjamindpedigo@gmail.com> * Added an `ax` argument for `screeplot` * Add ax argument to screeplot (now returns None) * add a return value for screeplot() * Refactored for best practices * Fixed Matplotlib 3.8 compatibility issues (#1049) * specify angle as kwarg * try removing some maybe unnecessary code? * fight with mypy * black * fix sorts * try switch to explain * fix intersphinx * other instances of wrong tutorial intersphinx * 3.3.0 release prep (#1050) * add release notes * bump version --------- Co-authored-by: Alex Loftus <alexloftus2004@gmail.com> Co-authored-by: Ben Johnson <bkj.322@gmail.com> Co-authored-by: bkj <ben@jataware.com> Co-authored-by: Prajwal Agrawal <61898798+kidkoder432@users.noreply.github.com>

loftusa added 3 commits April 3, 2021 13:15

test pytest ini

0a8a7ee

add binary_heatmap, updates to tutorial notebook

3ae1f60

test plotting

4254a05

loftusa commented Apr 4, 2021

View reviewed changes

graspologic/plot/plot.py Show resolved Hide resolved

loftusa commented Apr 4, 2021

View reviewed changes

graspologic/plot/plot.py Show resolved Hide resolved

loftusa commented Apr 4, 2021

View reviewed changes

graspologic/plot/plot.py Outdated Show resolved Hide resolved

loftusa requested review from bdpedigo and j1c April 4, 2021 19:49

bdpedigo reviewed Apr 5, 2021

View reviewed changes

pytest.ini Outdated Show resolved Hide resolved

loftusa and others added 4 commits April 5, 2021 19:27

re-add pytest.ini

88cc245

Merge branch 'dev' into heatmap-updates

1cf81b1

Merge branch 'dev' into heatmap-updates

1d3c93d

Merge branch 'dev' into heatmap-updates

116cf17

loftusa requested a review from bdpedigo April 12, 2021 17:17

loftusa added 2 commits April 12, 2021 13:23

Update plot.py

3489094

Fix a few bugs

add new tests

7570404

loftusa force-pushed the heatmap-updates branch from 11dfc85 to 7570404 Compare April 16, 2021 14:57

Merge branch 'dev' into heatmap-updates

0c776ae

bdpedigo reviewed May 12, 2021

View reviewed changes

loftusa added 2 commits July 14, 2021 09:49

Update setup.cfg

faba722

Merge remote-tracking branch 'upstream/dev' into dev

0e0e47f

loftusa added 4 commits August 24, 2021 09:20

Merge branch 'dev' of https://github.com/microsoft/graspologic into dev

0957812

merge

0f5e123

remove binary_heatmap

90ad691

mpl version req back to normal

50dcb7d

bdpedigo reviewed Sep 15, 2021

View reviewed changes

loftusa and others added 2 commits September 15, 2021 13:33

remove binary_heatmap import

74554a5

Merge branch 'dev' into heatmap-updates

7a82f10

bdpedigo approved these changes Sep 15, 2021

View reviewed changes

Merge branch 'dev' into heatmap-updates

44f372e

loftusa mentioned this pull request Oct 28, 2021

Allow int in xticklabels #813

Closed

loftusa and others added 2 commits October 29, 2021 11:44

black

2fec091

Merge branch 'dev' into heatmap-updates

da0232e

Merge branch 'dev' into heatmap-updates

a0250cf

Merge branch 'dev' into heatmap-updates

830b1ed

bdpedigo closed this Dec 13, 2021

bdpedigo reopened this Dec 13, 2021

loftusa added 3 commits January 18, 2022 15:37

Merge branch 'dev' into heatmap-updates

92bb95d

formatting fix

cb00d80

Merge branch 'heatmap-updates' of https://github.com/loftusa/graspologic

0aaadc9

into heatmap-updates

Merge branch 'dev' into heatmap-updates

69b8745

bdpedigo force-pushed the dev branch from 0823390 to aebdf1e Compare March 24, 2023 18:28

Merge branch 'dev' into heatmap-updates

05077e6

bdpedigo merged commit 4499f7c into graspologic-org:dev Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Heatmap updates #750

Heatmap updates #750

loftusa commented Apr 4, 2021 •

edited

Loading

netlify bot commented Apr 4, 2021 •

edited

Loading

bdpedigo commented Apr 5, 2021

loftusa commented Apr 5, 2021 •

edited

Loading

bdpedigo May 12, 2021

bdpedigo May 12, 2021

bdpedigo commented Aug 23, 2021

loftusa commented Aug 24, 2021

bdpedigo Sep 15, 2021

loftusa Sep 15, 2021

loftusa commented Oct 28, 2021

bdpedigo commented Oct 29, 2021

loftusa commented Oct 29, 2021 •

edited

Loading

bdpedigo commented Dec 7, 2021

loftusa commented Dec 7, 2021

bdpedigo commented Dec 7, 2021

bdpedigo commented Dec 13, 2021

bdpedigo commented Dec 13, 2021

loftusa commented Jan 18, 2022

bdpedigo commented Jun 27, 2022

Heatmap updates #750

Heatmap updates #750

Conversation

loftusa commented Apr 4, 2021 • edited Loading

netlify bot commented Apr 4, 2021 • edited Loading

bdpedigo commented Apr 5, 2021

loftusa commented Apr 5, 2021 • edited Loading

bdpedigo May 12, 2021

Choose a reason for hiding this comment

bdpedigo May 12, 2021

Choose a reason for hiding this comment

bdpedigo commented Aug 23, 2021

loftusa commented Aug 24, 2021

bdpedigo Sep 15, 2021

Choose a reason for hiding this comment

loftusa Sep 15, 2021

Choose a reason for hiding this comment

loftusa commented Oct 28, 2021

bdpedigo commented Oct 29, 2021

loftusa commented Oct 29, 2021 • edited Loading

bdpedigo commented Dec 7, 2021

loftusa commented Dec 7, 2021

bdpedigo commented Dec 7, 2021

bdpedigo commented Dec 13, 2021

bdpedigo commented Dec 13, 2021

loftusa commented Jan 18, 2022

bdpedigo commented Jun 27, 2022

loftusa commented Apr 4, 2021 •

edited

Loading

netlify bot commented Apr 4, 2021 •

edited

Loading

loftusa commented Apr 5, 2021 •

edited

Loading

loftusa commented Oct 29, 2021 •

edited

Loading