Trying to avoid subdirectory overload - but it doesn't work yet #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickjparkinson
commented
Jun 1, 2023
| @@ -171,6 +173,11 @@ grattan_save <- function(filename, | |||
|
|
|||
| # create subdirectory | |||
| dir <- tools::file_path_sans_ext(filename) | |||
|
|
|||
| if (isFALSE(subdirectory)) { | |||
There was a problem hiding this comment.
I'm sure there is a more elegant way than this - any hints?
|
I can't help but feel partly responsible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@raisin-toast - I had a crack but I just cannot seem to get this change to work.
It seems to work fine with .png. But as soon as we go to saving .pptx, it doesn't like the filenames. I think lines 203 and 221 are the problems. Any hints?