Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need to copy protogen files from lib/teleterm to packages/teleterm #16621

Closed
ravicious opened this issue Sep 22, 2022 · 1 comment
Closed

Remove the need to copy protogen files from lib/teleterm to packages/teleterm #16621

ravicious opened this issue Sep 22, 2022 · 1 comment
Labels
blocked is blocked by another item - please include the blocker grpc Issues related to gRPC refactoring teleport-connect Issues related to Teleport Connect.

Comments

@ravicious
Copy link
Member

Blocked by #15164.

The readme in packages/teleterm explains how to copy over the protogen files. Once webapps is merged into teleport (#15164), we should be able to tell buf to put the Go protogen files in lib/teleterm/api/protogen/golang and the JS files in webapps/packages/teleterm/src/services/tshd/v1/.

This is different from #15955 which is about protos for the gRPC server running in the shared process of the Electron app.
@ravicious ravicious added refactoring blocked is blocked by another item - please include the blocker teleport-connect Issues related to Teleport Connect. labels Sep 22, 2022
@ravicious ravicious mentioned this issue Sep 22, 2022
Merged
@ravicious ravicious added the grpc Issues related to gRPC label Oct 18, 2022
@ravicious
Copy link
Member Author

Done in #20810.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked is blocked by another item - please include the blocker grpc Issues related to gRPC refactoring teleport-connect Issues related to Teleport Connect.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ravicious