Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsh option: only populate ssh agent and not save identity files #4863

Closed
ollyg opened this issue Nov 17, 2020 · 7 comments
Closed

tsh option: only populate ssh agent and not save identity files #4863

ollyg opened this issue Nov 17, 2020 · 7 comments
Assignees
Labels
tsh tsh - Teleport's command line tool for logging into nodes running Teleport. ux
Milestone

Comments

@ollyg
Copy link

ollyg commented Nov 17, 2020

Feature Request

A command line option for tsh which would suppress storage of the identity files (certificates) and only populate the SSH Agent. An error is thrown if this is requested and the Agent is not available, or the --out option is also provided. For example:

tsh login --proxy=proxy.example.com --agent-only

Motivation

In order to avoid the security risk of certificates being farmed from a user's home directory and used to access a Cluster. Identity files would only remain in memory within the Agent on the local machine.

Who's it for?

Anyone - OSS User, Pro, Enterprise

Other Information

  • I tried setting --out=/dev/null but it stopped the Agent from being populated as well. Perhaps Agent step requires the identity files on disk already?
  • I wonder if this is going to stop tsh status from working?
  • I will try to find the time to patch and PR but no promises.
  • We are an Enterprise customer already - issue here as discussed with @webvictim on Slack support.
@ollyg ollyg changed the title tsh option to only populate ssh agent and not save identity files/certificates tsh option: only populate ssh agent and not save identity files/certificates Nov 17, 2020
@ollyg ollyg changed the title tsh option: only populate ssh agent and not save identity files/certificates tsh option: only populate ssh agent and not save identity files Nov 17, 2020
@russjones russjones added tsh tsh - Teleport's command line tool for logging into nodes running Teleport. ux labels Nov 17, 2020
@russjones russjones added this to the 5.1 "San Diego" milestone Nov 24, 2020
@russjones
Copy link
Contributor

Change the UX of tsh to reduce the number of flags to improve to flow here.

@russjones
Copy link
Contributor

@xacrimon Can you implement RFD #18 to resolve this issue?

@xacrimon
Copy link
Contributor

xacrimon commented Mar 2, 2021

on it

@webvictim
Copy link
Contributor

webvictim commented Mar 12, 2021

@travelton raised an excellent point: we should also expose an RBAC setting to enforce that certificates can only be stored in an SSH agent and must not be written to disk.

@xacrimon
Copy link
Contributor

Should we do this in a different PR and open a new issue for it?

@webvictim
Copy link
Contributor

@xacrimon Yes, let's not delay the current implementation.

@xacrimon
Copy link
Contributor

Solved by #5825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tsh tsh - Teleport's command line tool for logging into nodes running Teleport. ux
Projects
None yet
Development

No branches or pull requests

5 participants