fix(Tab): click on tabs should not generate 'submit' event #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
ma-efremoff
force-pushed
the
ma-efremoff/tab
branch
from
36502ad to
03534a3
Compare
|
Visual Tests Report is ready. |
ma-efremoff
changed the title
type="button"
amje
requested changes
Feb 10, 2025
src/components/tabs/Tab.tsx
Outdated
| @@ -38,7 +38,7 @@ export const Tab = React.forwardRef<HTMLAnchorElement | HTMLButtonElement, TabPr | |||
| } | |||
|
|
|||
| return ( | |||
| <button {...tabProps} ref={ref as React.Ref<HTMLButtonElement>}> | |||
| <button type="button" {...tabProps} ref={ref as React.Ref<HTMLButtonElement>}> | |||
There was a problem hiding this comment.
Place this after tabProps spread to ensure this attribute
ma-efremoff
force-pushed
the
ma-efremoff/tab
branch
from
03534a3 to
bd731c5
Compare
amje
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.