Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: service access restriction covers motorway fill #3279

Closed
giggls opened this issue Jun 26, 2018 · 2 comments
Closed

regression: service access restriction covers motorway fill #3279

giggls opened this issue Jun 26, 2018 · 2 comments

Comments

@giggls
Copy link

giggls commented Jun 26, 2018

Expected behavior

as rendered up to v4.11.0

Actual behavior

as rendered from v4.12.0

Links and screenshots illustrating the problem

Starting from v4.12.0 (at least, I did not use git bisect) service way fill seems to be rendered above motorway. Attached are two files illustrating this behavior.
v4.11.0:
test-construction-v4 11 0
v4.12.0
test-construction-v4 12 0

Service way is right above the "H" from "Dreieck Hochrhein" exit name.

@giggls giggls changed the title regression: service-fill above covers motorway regression: service-fill covers motorway Jun 26, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Jun 26, 2018
@sommerluk
Copy link
Collaborator

Rendering in v4.12.0 at scale factor 5:
screenshot 1

The service road’s fill is rendered correctly below the motorway link’s fill. The service road’s access restriction (.access::fill) is rendered incorrectly above the motorway link’s fill. This is indeed a regression in #2640. The attachment within which the road fills were rendered was called ::fill before, but in #2640 it has been renamed, while .access::fill remained unchanged.

@sommerluk sommerluk changed the title regression: service-fill covers motorway regression: service access restriction covers motorway Jun 27, 2018
@sommerluk sommerluk changed the title regression: service access restriction covers motorway regression: service access restriction covers motorway fill Jun 27, 2018
@sommerluk
Copy link
Collaborator

Closing as the commit that had introduced this regression has been reverted. (I’ll take this into account when doing a new PR for unpaved roads.)

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants