Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add a tree component #1622

Merged
merged 1 commit into from
Jul 26, 2023
Merged

feat(design): add a tree component #1622

merged 1 commit into from
Jul 26, 2023

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Jun 21, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, we don't have any way to describe a tree of elements with an aesthetic and usable design.

Fixes: N/A

What is the new behavior?

This adds such a component.

We've also added considerations for "flat" trees, e.g. trees that visually look like trees, but semantically are merely flat lists.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@damienwebdev damienwebdev requested a review from xelaint June 21, 2021 18:37
@xelaint xelaint marked this pull request as ready for review July 2, 2021 21:05
@xelaint xelaint requested review from a team as code owners July 2, 2021 21:05
libs/design/tree/src/tree-item/tree-item.component.ts Outdated Show resolved Hide resolved
libs/design/tree/src/tree-item/tree-item.component.ts Outdated Show resolved Hide resolved
libs/design/tree/src/tree-item/tree-item.component.ts Outdated Show resolved Hide resolved
libs/design/tree/src/tree-item/tree-item.component.spec.ts Outdated Show resolved Hide resolved
libs/design/tree/src/tree-item/tree-item.component.spec.ts Outdated Show resolved Hide resolved
libs/design/tree/src/tree-item/tree-item.component.ts Outdated Show resolved Hide resolved
libs/design/tree/src/README.md Outdated Show resolved Hide resolved
@xelaint xelaint added the package: design @daffodil/design label Jul 13, 2021
@xelaint xelaint added the feat a new feature, enhancement, or improvement label Jul 13, 2021
@damienwebdev damienwebdev self-assigned this Jul 28, 2021
@xelaint xelaint force-pushed the tree-component branch 4 times, most recently from e5798bb to 6e015fe Compare September 7, 2021 13:49
@xelaint
Copy link
Member

xelaint commented Sep 7, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Daffio changes should be a separate PR

@xelaint xelaint force-pushed the tree-component branch 2 times, most recently from 61078b1 to f3117ae Compare September 14, 2021 14:37
@xelaint
Copy link
Member

xelaint commented Sep 14, 2021

I think the Daffio changes should be a separate PR

@griest024 Split the PR, implementation is now in #1824

libs/design/tree/src/tree-item/tree-item.component.ts Outdated Show resolved Hide resolved
libs/design/tree/src/tree/tree.component.ts Outdated Show resolved Hide resolved
libs/design/tree/src/README.md Outdated Show resolved Hide resolved
Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tree does not appear in the sidebar list. Navigating manually to /tree throws this error:

ERROR Error: Uncaught (in promise): NotSupportedError: Failed to execute 'define' on 'CustomElementRegistry': the name "basic-tree-example" has already been used with this registry

@xelaint xelaint force-pushed the tree-component branch 2 times, most recently from acba271 to eac5918 Compare January 11, 2022 19:44
@damienwebdev damienwebdev force-pushed the tree-component branch 3 times, most recently from 3a2d960 to 3baf200 Compare April 24, 2023 21:07
@damienwebdev damienwebdev force-pushed the tree-component branch 2 times, most recently from 1eb530e to f84f552 Compare July 22, 2023 11:25
@damienwebdev damienwebdev requested a review from a team as a code owner July 26, 2023 12:49
Co-authored-by: Elain Tsai <xelaint@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat a new feature, enhancement, or improvement package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

5 participants