-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): add a tree component #1622
Conversation
e5798bb
to
6e015fe
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Daffio changes should be a separate PR
61078b1
to
f3117ae
Compare
@griest024 Split the PR, implementation is now in #1824 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tree does not appear in the sidebar list. Navigating manually to /tree
throws this error:
ERROR Error: Uncaught (in promise): NotSupportedError: Failed to execute 'define' on 'CustomElementRegistry': the name "basic-tree-example" has already been used with this registry
acba271
to
eac5918
Compare
a98cdf6
to
e14b5f3
Compare
3a2d960
to
3baf200
Compare
1eb530e
to
f84f552
Compare
da124f2
to
e0e8e13
Compare
Co-authored-by: Elain Tsai <xelaint@gmail.com>
e0e8e13
to
f211e48
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, we don't have any way to describe a tree of elements with an aesthetic and usable design.
Fixes: N/A
What is the new behavior?
This adds such a component.
We've also added considerations for "flat" trees, e.g. trees that visually look like trees, but semantically are merely flat lists.
Does this PR introduce a breaking change?
Other information