Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,product,category)!: type model factory create partial #1835

Merged

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Sep 20, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Model factories do not type the partial parameter of the create method.
Fixes: #1779

What is the new behavior?

  • Model factories type the partial.
  • Mock class constructor args typed through model factory superclass constructor args

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Ensure that partial arguments do not violate the model type.

Other information

Relies on #1834

@griest024 griest024 added package: product @daffodil/product package: core @daffodil/core labels Sep 20, 2021
@griest024 griest024 requested a review from a team as a code owner September 20, 2021 05:35
@griest024 griest024 marked this pull request as draft September 20, 2021 05:35
@griest024 griest024 force-pushed the feat/core/testing/factory/partial-types branch from c430331 to c6daa7f Compare November 24, 2023 01:48
@griest024 griest024 marked this pull request as ready for review November 24, 2023 01:48
@griest024 griest024 self-assigned this Nov 24, 2023
@griest024 griest024 changed the title feat(core, product): type model factory create partial feat(core,product,category): type model factory create partial Nov 24, 2023
@griest024 griest024 changed the title feat(core,product,category): type model factory create partial feat(core,product,category)!: type model factory create partial Nov 24, 2023
@griest024 griest024 force-pushed the feat/core/testing/factory/partial-types branch from c6daa7f to d478102 Compare November 24, 2023 04:46
@griest024 griest024 merged commit 6efc2c4 into graycoreio:develop Nov 24, 2023
49 checks passed
@gray-bot gray-bot mentioned this pull request Nov 24, 2023
@griest024 griest024 deleted the feat/core/testing/factory/partial-types branch November 24, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @daffodil/core package: product @daffodil/product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] DaffModelFactory should type partial parameters
1 participant