Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search*)!: add incremental driver call #2455

Merged

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2383

Does this PR introduce a breaking change?

[x] Yes
[ ] No

DaffSearchDriverInterface#incremental was added

Other information

BREAKING CHANGE: `DaffSearchDriverInterface#incremental` was added
@griest024 griest024 added layer: driver This PR or issue is related to the driver layer of Daffodil package: search @daffodil/search package: search-product @daffodil/search-product package: search-category @daffodil/search-category labels May 25, 2023
@griest024 griest024 requested a review from a team as a code owner May 25, 2023 13:57
@griest024 griest024 added the status: awaiting review This PR is awaiting review label May 25, 2023
@griest024 griest024 merged commit d112bcd into graycoreio:develop May 25, 2023
@gray-bot gray-bot mentioned this pull request May 25, 2023
@griest024 griest024 deleted the feat/search/driver/incremental branch May 29, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: driver This PR or issue is related to the driver layer of Daffodil package: search @daffodil/search package: search-category @daffodil/search-category package: search-product @daffodil/search-product status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Incremental Search Driver Call
2 participants