Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: rename native select sass and paths #2475

Merged

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Jun 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Part of: #416

Does this PR introduce a breaking change?

[x] Yes
[ ] No

daff-select-theme -> daff-native-select-theme

Other information

BREAKING CHANGE: `daff-select-theme` -> `daff-native-select-theme`
@griest024 griest024 added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change status: awaiting review This PR is awaiting review labels Jun 15, 2023
@griest024 griest024 requested a review from a team as a code owner June 15, 2023 20:56
@griest024
Copy link
Member Author

needed for #2458

Copy link
Member

@xelaint xelaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file structure and naming should be updated too. There's no need to nest all the files under the select folder, and all files should be renamed to native-select to avoid confusion.

Screen Shot 2023-06-15 at 5 00 10 PM

@griest024
Copy link
Member Author

griest024 commented Jun 15, 2023

@xelaint changed

libs/design/scss/theme.scss Outdated Show resolved Hide resolved
Co-authored-by: Elain T. <xelaint@gmail.com>
@griest024 griest024 merged commit 990919f into graycoreio:develop Jun 15, 2023
@xelaint xelaint changed the title feat(design)!: rename native select sass and paths feat(design): rename native select sass and paths Jun 15, 2023
@xelaint xelaint changed the title feat(design): rename native select sass and paths feat(design)!: rename native select sass and paths Jun 15, 2023
@gray-bot gray-bot mentioned this pull request Jun 15, 2023
@griest024 griest024 deleted the feat/design/rename-native-select branch June 15, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants