Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): expose all of DaffStatusable to the public api #2485

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 27, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

DaffStatusable is only usable internally. It's currently a private interface.

Fixes: N/A

What is the new behavior?

DaffStatusable is part of the @daffodil/design public api.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added package: design @daffodil/design status: awaiting review This PR is awaiting review labels Jun 27, 2023
@xelaint xelaint self-assigned this Jun 27, 2023
@xelaint xelaint marked this pull request as ready for review June 27, 2023 17:51
@xelaint xelaint requested a review from a team as a code owner June 27, 2023 17:51
@xelaint xelaint changed the title feat(design): expose DaffStatusable to the public api feat(design): expose all of DaffStatusable to the public api Jun 27, 2023
@xelaint xelaint merged commit d82d703 into develop Jun 29, 2023
@gray-bot gray-bot mentioned this pull request Jun 27, 2023
@damienwebdev damienwebdev deleted the statusable-public branch July 21, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
Development

Successfully merging this pull request may close these issues.

1 participant