Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart): create cart automatically for add cart item #2493

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

the request will send a nully cart ID if it is not in storage

What is the new behavior?

a cart creation will be attempted if a cart ID is not present during a cart item add operation

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: cart @daffodil/cart layer: state This PR or issue is related to the redux state layer status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Jun 29, 2023
@griest024 griest024 self-assigned this Jun 29, 2023
@griest024 griest024 requested a review from a team as a code owner June 29, 2023 20:45
@griest024 griest024 closed this Jun 29, 2023
@griest024 griest024 reopened this Jun 29, 2023
@griest024 griest024 merged commit 88e5ef9 into graycoreio:develop Jun 29, 2023
@griest024 griest024 deleted the feat/cart/state/effects/item/create-automatically-for-add branch June 29, 2023 21:21
@gray-bot gray-bot mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: state This PR or issue is related to the redux state layer package: cart @daffodil/cart status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant