Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart)!: package prefix reducer initial state exports #2501

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

cart initial state are not exported and/or just named initialState

What is the new behavior?

they are correctly named and exported

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

BREAKING CHANGE: `initialState` -> `daffCartReducerInitialState`
@griest024 griest024 added package: cart @daffodil/cart layer: state This PR or issue is related to the redux state layer 🚨 breaking changes This PR or issue will cause a breaking change status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Jul 13, 2023
@griest024 griest024 requested a review from a team as a code owner July 13, 2023 17:15
@griest024 griest024 self-assigned this Jul 13, 2023
@griest024 griest024 merged commit c7b85d7 into graycoreio:develop Jul 13, 2023
@griest024 griest024 deleted the feat/cart/state/prefix-initial-state-exports branch July 13, 2023 17:24
@gray-bot gray-bot mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change layer: state This PR or issue is related to the redux state layer package: cart @daffodil/cart status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant