Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart-customer): remove cart ID from storage when unauthenticated #2507

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

the cart ID is removed from storage via an effect and incurs a race condition against client cache reset

What is the new behavior?

the cart ID removal is performed synchronously before client cache reset

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added layer: state This PR or issue is related to the redux state layer package: cart-customer @daffodil/cart-customer status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Jul 13, 2023
@griest024 griest024 requested a review from a team as a code owner July 13, 2023 18:14
@griest024 griest024 self-assigned this Jul 13, 2023
@griest024 griest024 merged commit e8fc2c4 into graycoreio:develop Jul 13, 2023
@griest024 griest024 deleted the feat/cart-customer/state/remove-cart-id-from-storage branch July 13, 2023 18:26
@gray-bot gray-bot mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: state This PR or issue is related to the redux state layer package: cart-customer @daffodil/cart-customer status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant