-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress Indicator/Bar updates #2510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xelaint
added
package: design
@daffodil/design
status: awaiting review
This PR is awaiting review
labels
Jul 18, 2023
xelaint
force-pushed
the
progress-bar
branch
from
December 18, 2023 22:31
8ee9a07
to
78e7e39
Compare
xelaint
force-pushed
the
progress-bar
branch
2 times, most recently
from
January 24, 2024 02:40
4445622
to
9d20185
Compare
damienwebdev
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Progress indicator styles aren't actually working. The naming is not aligned with the aria role. It automatically animates on render.
Fixes: #639
Part of: #1340
What is the new behavior?
DaffProgressIndicatorComponent
toDaffProgressBarComponent
. Added deprecation notice for progress indicator.Does this PR introduce a breaking change?
Other information