Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cart): cart resolution effects unsafely call storage in SSR #2545

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

cart resolver effects call storage always, which breaks SSR

What is the new behavior?

the platform is checked before calling the storage service. the storage service is only called in the browser

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: cart @daffodil/cart layer: state This PR or issue is related to the redux state layer status: awaiting review This PR is awaiting review labels Aug 11, 2023
@griest024 griest024 requested a review from a team as a code owner August 11, 2023 23:59
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit d6e0468 into graycoreio:develop Sep 19, 2023
@gray-bot gray-bot mentioned this pull request Sep 19, 2023
@griest024 griest024 deleted the fix/cart/state/effects/cart-resolver-breaks-ssr branch September 28, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: state This PR or issue is related to the redux state layer package: cart @daffodil/cart status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants