Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): deprecate theming option for paginators and update styles to work in both dark and light mode #2575

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Sep 27, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Default colors don't work in dark mode. There are theming options for paginator.

Fixes: #2044

What is the new behavior?

Deprecate color property for paginator. Update default styles to work in both dark and light mode.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Sep 27, 2023
@xelaint xelaint self-assigned this Sep 27, 2023
@xelaint xelaint requested a review from a team as a code owner September 27, 2023 22:23
@xelaint xelaint merged commit ec50bcb into develop Sep 27, 2023
12 checks passed
@gray-bot gray-bot mentioned this pull request Sep 26, 2023
@damienwebdev damienwebdev deleted the paginator-theming branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

[FEAT] Paginator theming updates
1 participant