Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design-land): add file tabs back to code preview and allow content to be hidden #2578

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Oct 2, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

File tabs are not included in the code preview. The content for examples are always shown.

Fixes: #2568

What is the new behavior?

Add file tabs because some design examples benefit from seeing the component implementation. Add property to hide or show example content. This is beneficial if I want to display a block of formatted code without wanting to display the content.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added this to the v0.4.0 - The Big Docs update milestone Oct 2, 2023
@xelaint xelaint requested a review from a team as a code owner October 2, 2023 14:56
@xelaint xelaint self-assigned this Oct 2, 2023
@xelaint xelaint merged commit 37e02bd into develop Oct 2, 2023
@gray-bot gray-bot mentioned this pull request Oct 2, 2023
@damienwebdev damienwebdev deleted the code-preview-update branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] Allow design land code preview to hide content
1 participant