Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): update nav list background color to animate via opacity for performance #2583

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Oct 12, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Nav list has a background hover style that is being animated through transitions. Background is not a property in the GPU and animating it causes slower performance.

Part of: #2446

What is the new behavior?

Add the background hover color via the after pseudo-selector and animate it via the opacity property.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Oct 12, 2023
@xelaint xelaint self-assigned this Oct 12, 2023
@xelaint xelaint requested a review from a team as a code owner October 12, 2023 18:40
@xelaint xelaint merged commit bfccd2c into develop Oct 12, 2023
12 checks passed
@gray-bot gray-bot mentioned this pull request Oct 12, 2023
@damienwebdev damienwebdev deleted the list-gpu-animation branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

1 participant