Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): remove bogus combinator from sidebar style #2601

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Nov 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2600

What is the new behavior?

side-fixed sidebars that are nested within the primary sidebar viewport is now positioned correctly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Nov 14, 2023
@xelaint xelaint requested a review from a team as a code owner November 14, 2023 21:25
@xelaint xelaint merged commit 88205b7 into develop Nov 15, 2023
12 checks passed
@gray-bot gray-bot mentioned this pull request Nov 15, 2023
@xelaint xelaint deleted the sidebar-bogus-combinator branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sidebar Component is using a bogus SASS combinator
1 participant