feat(all)!: upgrade to Angular v17 #2728

griest024 · 2024-01-18T19:18:51Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Upgrade your app to Angular v17

Other information

fixes #2707

griest024 · 2024-01-22T20:00:58Z

blocked by angular/angular-cli#26922

@16

BREAKING CHANGE: Angular has been upgraded to v16 ng update @angular/{pwa,core,cdk,cli,animations,common,compiler,elements,forms,platform-browser,platform-browser-dynamic,platform-server,router,service-worker,compiler -cli,language-service}@16.0.0 @nguniversal/{builders,express-engine}@16.0.0 @angular-devkit/{schematics,build-angular,core}@16. 0.0 @angular-eslint/{builder,eslint-plugin,eslint-plugin-template,schematics,template-parser}@16.0.0 @ngrx/{effects,entity,rout er-store,schematics,store,store-devtools}@16.0.0 ng-packagr@16.0.0 @angular-devkit/architect@0.1602.11 angular-in-memory-web-ap i@0.16.0 typescript@4.9.3 --force The installed Angular CLI version is outdated. Installing a temporary Angular CLI versioned 16.2.11 to perform the update. ✔ Packages successfully installed. Using package manager: npm Collecting installed dependencies... Found 106 dependencies. Fetching dependency metadata from registry... Updating package.json with dependency @angular-devkit/architect @ "0.1602.11" (was "0.1502.9")... Updating package.json with dependency @angular-devkit/build-angular @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular-devkit/core @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular-devkit/schematics @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular-eslint/builder @ "16.0.0" (was "15.2.1")... Updating package.json with dependency @angular-eslint/eslint-plugin @ "16.0.0" (was "15.2.1")... Updating package.json with dependency @angular-eslint/eslint-plugin-template @ "16.0.0" (was "15.2.1")... Updating package.json with dependency @angular-eslint/schematics @ "16.0.0" (was "15.2.1")... Updating package.json with dependency @angular-eslint/template-parser @ "16.0.0" (was "15.2.1")... Updating package.json with dependency @angular/cli @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/compiler-cli @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/language-service @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @ngrx/store-devtools @ "16.0.0" (was "15.4.0")... Updating package.json with dependency @nguniversal/builders @ "16.0.0" (was "15.2.1")... Updating package.json with dependency ng-packagr @ "16.0.0" (was "15.2.2")... Updating package.json with dependency typescript @ "4.9.3" (was "4.8.4")... Updating package.json with dependency @angular/animations @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/cdk @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/common @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/compiler @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/core @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/elements @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/forms @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/platform-browser @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/platform-browser-dynamic @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/platform-server @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/pwa @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/router @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @angular/service-worker @ "16.0.0" (was "15.2.9")... Updating package.json with dependency @ngrx/effects @ "16.0.0" (was "15.4.0")... Updating package.json with dependency @ngrx/entity @ "16.0.0" (was "15.4.0")... Updating package.json with dependency @ngrx/router-store @ "16.0.0" (was "15.4.0")... Updating package.json with dependency @ngrx/schematics @ "16.0.0" (was "15.4.0")... Updating package.json with dependency @ngrx/store @ "16.0.0" (was "15.4.0")... Updating package.json with dependency @nguniversal/express-engine @ "16.0.0" (was "15.2.1")... Updating package.json with dependency angular-in-memory-web-api @ "0.16.0" (was "0.15.0")... Updating package.json with dependency zone.js @ "0.13.3" (was "0.11.5")... UPDATE package.json (4251 bytes) ✔ Packages successfully installed. ** Executing migrations of package '@angular-eslint/schematics' ** ▸ Updates @angular-eslint to v16. UPDATE package.json (4252 bytes) ✔ Packages installed successfully. Migration completed (1 file modified). ** Executing migrations of package '@angular/cli' ** ▸ Remove 'defaultProject' option from workspace configuration. The project to use will be determined from the current working directory. Migration completed (No changes made). ▸ Replace removed 'defaultCollection' option in workspace configuration with 'schematicCollections'. Migration completed (No changes made). ▸ Update the '@angular-devkit/build-angular:server' builder configuration to disable 'buildOptimizer' for non optimized builds. UPDATE angular.json (71902 bytes) Migration completed (1 file modified). ** Executing migrations of package '@angular/cdk' ** ▸ Updates the Angular CDK to v16. Skipping migration for project demo-e2e. Unable to determine 'tsconfig.json' file in workspace config. Skipping migration for project daffio-e2e. Unable to determine 'tsconfig.json' file in workspace config. Skipping migration for project design-land-e2e. Unable to determine 'tsconfig.json' file in workspace config. ✓ Updated Angular CDK to version 16 Migration completed (No changes made). ** Executing migrations of package '@angular/core' ** ▸ In Angular version 15.2, the guard and resolver interfaces (CanActivate, Resolve, etc) were deprecated. This migration removes imports and 'implements' clauses that contain them. UPDATE apps/demo/src/app/cart/routing-resolvers/resolvers/cart-resolver.service.ts (1198 bytes) UPDATE apps/demo/src/app/cart/routing-resolvers/resolvers/empty-cart-resolver.service.ts (942 bytes) UPDATE libs/external-router/routing/src/guard/existence.guard.ts (3506 bytes) UPDATE libs/product/routing/src/resolvers/product-page-id/product-page-id.resolver.ts (1369 bytes) UPDATE libs/product/routing/src/resolvers/product-page/product-page.resolver.ts (790 bytes) UPDATE libs/product/routing/src/resolvers/product-page-url/product-page-url.resolver.ts (1700 bytes) UPDATE libs/category/routing/src/resolvers/category-page-id/category-page-id.resolver.ts (1815 bytes) UPDATE libs/category/routing/src/resolvers/category-page/category-page.resolver.ts (772 bytes) UPDATE libs/category/routing/src/resolvers/category-page-url/category-page-url.resolver.ts (1703 bytes) UPDATE libs/cart/routing/src/guards/billing-address/billing-address.guard.ts (1277 bytes) UPDATE libs/cart/routing/src/guards/resolved-cart/resolved-cart.guard.ts (1781 bytes) UPDATE libs/cart/routing/src/guards/resolve-cart/resolve-cart.guard.ts (3308 bytes) UPDATE libs/cart/routing/src/guards/cart-items/cart-items.guard.ts (1409 bytes) UPDATE libs/cart/routing/src/guards/in-stock-items/in-stock-items.guard.ts (1609 bytes) UPDATE libs/cart/routing/src/guards/payment-method/payment-method.guard.ts (1268 bytes) UPDATE libs/cart/routing/src/guards/shipping-address/shipping-address.guard.ts (1286 bytes) UPDATE libs/cart/routing/src/guards/shipping-method/shipping-method.guard.ts (1277 bytes) UPDATE libs/cart/routing/src/guards/order-result/order-result.guard.ts (1020 bytes) UPDATE libs/cart/routing/src/resolvers/cart-resolver.service.ts (1837 bytes) UPDATE libs/cart/routing/src/resolvers/empty-cart-resolver.service.ts (1402 bytes) UPDATE apps/daffio/src/app/api/resolvers/api-list-resolver.service.ts (715 bytes) UPDATE apps/daffio/src/app/docs/resolvers/docs-resolver.service.ts (1055 bytes) UPDATE libs/auth/routing/src/guards/member-only.guard.ts (1690 bytes) UPDATE libs/auth/routing/src/guards/guest-only.guard.ts (1689 bytes) UPDATE libs/auth/routing/src/guards/reset-password.guard.ts (847 bytes) UPDATE libs/paypal/routing/src/guards/express-payment/guard.ts (1283 bytes) UPDATE libs/order/routing/src/guards/placed-order/placed-order.guard.ts (997 bytes) UPDATE libs/search/routing/src/resolvers/search/search.resolver.ts (1844 bytes) UPDATE libs/customer/routing/src/guards/clear-errors.guard.ts (627 bytes) UPDATE libs/customer/routing/src/resolvers/customer.resolver.ts (474 bytes) UPDATE libs/customer-store-credit/routing/src/guards/clear-errors.guard.ts (673 bytes) UPDATE libs/customer-store-credit/routing/src/resolvers/customer-store-credit.resolver.ts (542 bytes) UPDATE libs/cart-store-credit/routing/src/guards/clear-errors.guard.ts (653 bytes) UPDATE libs/customer-payment/routing/src/guards/clear-errors.guard.ts (656 bytes) UPDATE libs/customer-payment/routing/src/resolvers/customer-payments.resolver.ts (517 bytes) UPDATE libs/seo/integration-tests/state/provided-canonical-updates.spec.ts (5800 bytes) Migration completed (36 files modified). ▸ As of Angular v16, the `moduleId` property of `@Component` is deprecated as it no longer has any effect. Migration completed (No changes made). ** Executing migrations of package '@ngrx/store' ** ▸ The road to v16.0-beta. Migration completed (No changes made).

BREAKING CHANGE: Angular has been upgraded to v17 ng update @angular/{pwa,core,cdk,cli,animations,common,compiler,elements,forms,platform-browser,platform-browser-dynamic,platform-server,router,service-worker,compiler-cli,language-service}@17.0.0 @angular-devkit/{schematics,build-angular,core}@17.0.0 @angular-eslint/{builder,eslint-plugin,eslint-plugin-templat e,schematics,template-parser}@17.0.0 @ngrx/{effects,entity,router-store,schematics,store,store-devtools}@17.0.0 ng-packag r@17.0.0 @angular-devkit/architect@0.1700.9 angular-in-memory-web-api@0.17.0 typescript@5.3 @fortawesome/angular-fontawes ome@0.14 --force The installed Angular CLI version is outdated. Installing a temporary Angular CLI versioned 17.0.9 to perform the update. ✔ Packages successfully installed. Using package manager: npm Collecting installed dependencies... Found 106 dependencies. Fetching dependency metadata from registry... Package "@angular-devkit/build-angular" has an incompatible peer dependency to "typescript" (requires ">=5.2 <5.3", would install "5.3.3") Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript" (requires ">=5.2 <5.3", would install "5.3.3") Package "ng-packagr" has an incompatible peer dependency to "typescript" (requires ">=5.2 <5.3", would install "5.3.3") Package "@angular-devkit/build-angular" has an incompatible peer dependency to "typescript" (requires ">=5.2 <5.3", would install "5.3.3"). Updating package.json with dependency @angular-devkit/architect @ "0.1700.9" (was "0.1602.11")... Updating package.json with dependency @angular-devkit/build-angular @ "17.0.0" (was "16.2.11")... Updating package.json with dependency @angular-devkit/core @ "17.0.0" (was "16.2.11")... Updating package.json with dependency @angular-devkit/schematics @ "17.0.0" (was "16.2.11")... Updating package.json with dependency @angular-eslint/builder @ "17.0.0" (was "16.3.1")... Updating package.json with dependency @angular-eslint/eslint-plugin @ "17.0.0" (was "16.3.1")... Updating package.json with dependency @angular-eslint/eslint-plugin-template @ "17.0.0" (was "16.3.1")... Updating package.json with dependency @angular-eslint/schematics @ "17.0.0" (was "16.3.1")... Updating package.json with dependency @angular-eslint/template-parser @ "17.0.0" (was "16.3.1")... Updating package.json with dependency @angular/cli @ "17.0.0" (was "16.2.11")... Updating package.json with dependency @angular/compiler-cli @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/language-service @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @ngrx/store-devtools @ "17.0.0" (was "16.3.0")... Updating package.json with dependency ng-packagr @ "17.0.0" (was "16.2.3")... Updating package.json with dependency typescript @ "5.3.3" (was "4.9.5")... Updating package.json with dependency @angular/animations @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/cdk @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/common @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/compiler @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/core @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/elements @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/forms @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/platform-browser @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/platform-browser-dynamic @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/platform-server @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/pwa @ "17.0.0" (was "16.2.11")... Updating package.json with dependency @angular/router @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @angular/service-worker @ "17.0.0" (was "16.2.12")... Updating package.json with dependency @fortawesome/angular-fontawesome @ "0.14.1" (was "0.13.0")... Updating package.json with dependency @ngrx/effects @ "17.0.0" (was "16.3.0")... Updating package.json with dependency @ngrx/entity @ "17.0.0" (was "16.3.0")... Updating package.json with dependency @ngrx/router-store @ "17.0.0" (was "16.3.0")... Updating package.json with dependency @ngrx/schematics @ "17.0.0" (was "16.3.0")... Updating package.json with dependency @ngrx/store @ "17.0.0" (was "16.3.0")... Updating package.json with dependency angular-in-memory-web-api @ "0.17.0" (was "0.16.0")... Updating package.json with dependency zone.js @ "0.14.2" (was "0.13.3")... UPDATE package.json (4250 bytes) ✔ Packages successfully installed. ** Executing migrations of package '@angular-eslint/schematics' ** ▸ Updates @angular-eslint to v17. UPDATE package.json (4251 bytes) ✔ Packages installed successfully. Migration completed (1 file modified). ** Executing migrations of package '@angular/cli' ** ▸ Replace usages of '@nguniversal/builders' with '@angular-devkit/build-angular'. UPDATE angular.json (71918 bytes) UPDATE package.json (4211 bytes) Migration completed (2 files modified). ▸ Replace usages of '@nguniversal/' packages with '@angular/ssr'. RENAME apps/daffio/server/server.ts => apps/daffio/server/server.ts.bak CREATE apps/daffio/server/server.ts (2206 bytes) UPDATE package.json (4195 bytes) ✔ Packages installed successfully. Migration completed (2 files modified). ▸ Replace deprecated options in 'angular.json'. UPDATE angular.json (71896 bytes) Migration completed (1 file modified). ** Executing migrations of package '@ngrx/store-devtools' ** ▸ The road to v17-beta.1. UPDATE apps/daffio/src/app/app.module.ts (1866 bytes) UPDATE apps/demo/src/app/app.module.ts (1861 bytes) Migration completed (2 files modified). ** Executing migrations of package '@angular/cdk' ** ▸ Updates the Angular CDK to v17. Skipping migration for project demo-e2e. Unable to determine 'tsconfig.json' file in workspace config. Skipping migration for project daffio-e2e. Unable to determine 'tsconfig.json' file in workspace config. Skipping migration for project design-land-e2e. Unable to determine 'tsconfig.json' file in workspace config. ✓ Updated Angular CDK to version 17 Migration completed (No changes made). ** Executing migrations of package '@angular/core' ** ▸ Angular v17 introduces a new control flow syntax that uses the @ and } characters. This migration replaces the existing usages with their corresponding HTML entities. UPDATE apps/demo/src/app/misc/help-box/help-box.component.html (604 bytes) UPDATE apps/design-land/src/app/sidebar/sidebar.component.html (7697 bytes) UPDATE apps/design-land/src/app/foundations/variables/variables.component.html (2063 bytes) Migration completed (3 files modified). ▸ Updates `TransferState`, `makeStateKey`, `StateKey` imports from `@angular/platform-browser` to `@angular/core`. Migration completed (No changes made). ▸ CompilerOption.useJit and CompilerOption.missingTranslation are unused under Ivy. This migration removes their usage Migration completed (No changes made).

this replaces the separate client and server builds with a single build

this is apparently a requirement: angular/angular-cli#26922

this will cause the docs JSON files to 404

…eio#2728)

this fixes paulmillr/chokidar#1299

griest024 force-pushed the feat/all/angular-17 branch from 54a826e to 69948c0 Compare January 18, 2024 22:28

griest024 force-pushed the feat/all/angular-17 branch from 341debc to 4a51aff Compare January 22, 2024 20:05

griest024 added the status: blocked This PR or issue is blocked and cannot currently be progressed label Jan 22, 2024

griest024 marked this pull request as ready for review January 22, 2024 22:51

griest024 requested review from a team and damienwebdev as code owners January 22, 2024 22:51

griest024 marked this pull request as draft January 22, 2024 23:19

griest024 force-pushed the feat/all/angular-17 branch from f021607 to 4b0844a Compare January 23, 2024 16:40

griest024 marked this pull request as ready for review January 23, 2024 16:43

damienwebdev mentioned this pull request Jan 24, 2024

[FEAT] Convert Resolvers and Guards to function resolvers and can* functions #2737

Open

griest024 force-pushed the feat/all/angular-17 branch from df5ef70 to fd8e0a8 Compare January 24, 2024 19:10

griest024 added status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin and removed status: blocked This PR or issue is blocked and cannot currently be progressed labels Jan 24, 2024

griest024 force-pushed the feat/all/angular-17 branch 3 times, most recently from 3abec0e to 4276cba Compare January 25, 2024 16:07

griest024 added 9 commits January 25, 2024 16:13

chore: add additional nx cache folder to .gitignore (graycoreio#2728)

81bef44

test(all): fix zone imports in root test file (graycoreio#2728)

2626da8

feat(eslint-config): restore legacy lint rules (graycoreio#2728)

97e9203

feat(daffio): revert to module bootstrap in server (graycoreio#2728)

9b07f7d

build(daffio): use application builder (graycoreio#2728)

8ad49ea

this replaces the separate client and server builds with a single build

fix(all): ng packagr secondary entry points config (graycoreio#2728)

5dc1c85

build: update to es2022 (graycoreio#2728)

3ffcf26

griest024 added 5 commits January 25, 2024 16:19

build(design-land): use application builder (graycoreio#2728)

9e8d223

fix(daffio): add default export to main.server.ts (graycoreio#2728)

1e2174f

this is apparently a requirement: angular/angular-cli#26922

fix(daffio): api paths have leading slash (graycoreio#2728)

312a91b

this will cause the docs JSON files to 404

fix(daffio): replace LetModule imports with LetDirective (graycor…

8ba65b3

…eio#2728)

chore: pin @types/node version (graycoreio#2728)

8e07ccc

this fixes paulmillr/chokidar#1299

griest024 force-pushed the feat/all/angular-17 branch from 4276cba to 8e07ccc Compare January 25, 2024 16:19

griest024 merged commit 8e07ccc into graycoreio:develop Jan 25, 2024
52 of 53 checks passed

gray-bot mentioned this pull request Jan 25, 2024

chore: release 0.67.0 #2651

Merged

griest024 deployed to next January 25, 2024 16:36 — with GitHub Actions View deployment

gray-bot had a problem deploying to preview January 25, 2024 16:36 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(all)!: upgrade to Angular v17 #2728

feat(all)!: upgrade to Angular v17 #2728

griest024 commented Jan 18, 2024 •

edited

Loading

griest024 commented Jan 22, 2024

feat(all)!: upgrade to Angular v17 #2728

feat(all)!: upgrade to Angular v17 #2728

Conversation

griest024 commented Jan 18, 2024 • edited Loading

PR Checklist

PR Type

Does this PR introduce a breaking change?

Other information

griest024 commented Jan 22, 2024

griest024 commented Jan 18, 2024 •

edited

Loading