Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(design, daffio)!: update daff-gray palette name to daff-neutral #2736

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Palette is currently named daff-gray. The gray wording is confusing because the palette does not just have gray colors.

Fixes: #1894

What is the new behavior?

Update palette name to daff-neutral which will allow the palette to be defined with more flexibility.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@xelaint xelaint added package: daff.io @daffodil/daff.io package: design @daffodil/design labels Jan 22, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 22, 2024
@xelaint xelaint requested a review from a team as a code owner January 22, 2024 03:39
@xelaint xelaint self-assigned this Jan 22, 2024
@xelaint xelaint requested review from a team as code owners January 22, 2024 03:39
@xelaint xelaint changed the title refactor(design, daffio)!: update daff-gray palette name to daff-neutral refactor(design, daffio)!: update daff-gray palette name to daff-neutral Jan 22, 2024
@xelaint xelaint force-pushed the gray-palette-to-neutral branch from 2c99f97 to 7ba890d Compare January 22, 2024 11:10
@xelaint xelaint force-pushed the gray-palette-to-neutral branch from 7ba890d to 4ebb46a Compare January 22, 2024 11:17
@xelaint xelaint merged commit b219d31 into develop Jan 23, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jan 23, 2024
@xelaint xelaint deleted the gray-palette-to-neutral branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

[FEAT] Update palette name from daff-gray to daff-neutral
2 participants