-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render design examples in daffio #2909
Merged
griest024
merged 9 commits into
graycoreio:develop
from
griest024:fix/daffio/example-viewer-gone
Jul 16, 2024
Merged
feat: render design examples in daffio #2909
griest024
merged 9 commits into
graycoreio:develop
from
griest024:fix/daffio/example-viewer-gone
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moves the example viewer components to a `docs-components` package - changes the example rendering from a custom element based one to a component outlet one - adds custom element support for the example viewer container so it can be rendered when the markdown is rendered with `innerHtml` - converts example components to standalone so that they can be dynamically rendered - extracts internal package ignore constant in dgeni and adds new packages
griest024
added
docs
This issue is related to documentation
package: daff.io
@daffodil/daff.io
package: design
@daffodil/design
status: awaiting review
This PR is awaiting review
package: docs-utils
@daffodil/docs-utils
tools: dgeni
@daffodil/tools-dgeni
labels
Jul 12, 2024
@xelaint Can you acceptance test that design-land and daffio look correct to you? |
xelaint
requested changes
Jul 15, 2024
xelaint
requested changes
Jul 16, 2024
libs/docs-components/src/code-preview/component/code-preview.component.html
Outdated
Show resolved
Hide resolved
xelaint
requested changes
Jul 16, 2024
3 tasks
xelaint
approved these changes
Jul 16, 2024
Merged
damienwebdev
added a commit
that referenced
this pull request
Jul 18, 2024
This reverts commit 6bba42d.
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
This issue is related to documentation
package: daff.io
@daffodil/daff.io
package: design
@daffodil/design
package: docs-utils
@daffodil/docs-utils
status: awaiting review
This PR is awaiting review
tools: dgeni
@daffodil/tools-dgeni
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #2903
What is the new behavior?
docs-components
packageinnerHtml
Does this PR introduce a breaking change?
Other information