Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core,driver)!: move DaffInMemoryDataServiceInterface to @daffodil/driver/in-memory #3145

Merged
merged 2 commits into from
Oct 7, 2024
Merged

feat(core,driver)!: move DaffInMemoryDataServiceInterface to @daffodil/driver/in-memory #3145

merged 2 commits into from
Oct 7, 2024

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

DaffInMemoryDataServiceInterface is now exported from @daffodil/driver/in-memory and has been removed from @daffodil/core/testing

Other information

@griest024 griest024 added package: driver @daffodil/driver package: core @daffodil/core layer: driver This PR or issue is related to the driver layer of Daffodil 🚨 breaking changes This PR or issue will cause a breaking change status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin platform: in-memory labels Oct 4, 2024
@griest024 griest024 self-assigned this Oct 4, 2024
@griest024 griest024 requested a review from a team as a code owner October 4, 2024 18:45
@griest024
feat(core,driver)!: move DaffInMemoryDataServiceInterface to `@daff…
7bedbb5 
…odil/driver/in-memory`

BREAKING CHANGE: `DaffInMemoryDataServiceInterface` is now exported from `@daffodil/driver/in-memory` and has been removed from `@daffodil/core/testing`
@griest024 griest024 force-pushed the feat/driver/move-data-service branch from c2d5b2e to 7bedbb5 Compare October 4, 2024 19:17
@griest024 griest024 merged commit 87277c6 into graycoreio:develop Oct 7, 2024
51 checks passed
@gray-bot gray-bot mentioned this pull request Oct 3, 2024
Merged
@griest024 griest024 deleted the feat/driver/move-data-service branch October 7, 2024 13:22
gracetxgao pushed a commit to gracetxgao/daffodil that referenced this pull request Oct 24, 2024
@griest024 @gracetxgao
feat(core,driver)!: move DaffInMemoryDataServiceInterface to `@daff…
f983fa4 
…odil/driver/in-memory` (graycoreio#3145)

BREAKING CHANGE: `DaffInMemoryDataServiceInterface` is now exported from `@daffodil/driver/in-memory` and has been removed from `@daffodil/core/testing`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@griest024 griest024

Labels
🚨 breaking changes This PR or issue will cause a breaking change layer: driver This PR or issue is related to the driver layer of Daffodil package: core @daffodil/core package: driver @daffodil/driver platform: in-memory status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@griest024