Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): migrate to new in-memory module #3197

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Oct 10, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The demo creates its own in memory root backend. fixes: #3139, fixes: #2619, fixes: #3140

What is the new behavior?

The demo uses the new in memory module which obviates the need for apps to create their own root backend

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: demo @daffodil/demo layer: driver This PR or issue is related to the driver layer of Daffodil status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin platform: in-memory labels Oct 10, 2024
@griest024 griest024 requested review from a team as code owners October 10, 2024 16:24
@griest024 griest024 merged commit e4c3725 into graycoreio:develop Oct 10, 2024
8 checks passed
@griest024 griest024 deleted the feat/demo/drivers/in-mem/migrate-to-new-module branch October 10, 2024 17:00
@gray-bot gray-bot mentioned this pull request Oct 10, 2024
gracetxgao pushed a commit to gracetxgao/daffodil that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: driver This PR or issue is related to the driver layer of Daffodil package: demo @daffodil/demo platform: in-memory status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
1 participant