Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): configure defaults for status themes and add a new function that can be used to customize it #3291

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Oct 17, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Statusable components are currently directly referencing palettes to set the colors. This causes issues for theme switching as well as inconsistencies in color for statuses.

Fixes: #3287

What is the new behavior?

Added status defaults to daff-configure-theme and created a new function called daff-configure-theme-status for users to customize their own status themes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

…tion that can be used to customize status themes
@xelaint xelaint added package: design @daffodil/design status: awaiting review This PR is awaiting review labels Oct 17, 2024
@xelaint xelaint requested a review from damienwebdev October 17, 2024 13:45
@xelaint xelaint requested a review from a team as a code owner October 17, 2024 13:45
@xelaint xelaint changed the title feat(design): configure defaults for status themes and add a new function that can be used to customize status themes feat(design): configure defaults for status themes and add a new function that can be used to customize it Oct 17, 2024
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit cf4d2f7 into develop Oct 17, 2024
14 checks passed
@damienwebdev damienwebdev deleted the configure-theme-updates branch October 17, 2024 18:18
@gray-bot gray-bot mentioned this pull request Oct 17, 2024
gracetxgao pushed a commit to gracetxgao/daffodil that referenced this pull request Oct 24, 2024
This also adds a new function `daff-configure-theme-status` that can be used to customize status themes for users who want to change the status colors of their app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add status indicator palettes to configurable themes
2 participants