Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dgeni,daffio)!: align dgeni and daffio doc types #3333

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2819

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

although it doesn't break anything in the public API, the models that dgeni and daffio uses are different

Other information

@griest024 griest024 added package: daff.io @daffodil/daff.io status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin tools: dgeni @daffodil/tools-dgeni labels Nov 1, 2024
@griest024 griest024 self-assigned this Nov 1, 2024
@griest024 griest024 requested review from a team as code owners November 1, 2024 20:58
@griest024 griest024 merged commit b6bafdd into graycoreio:develop Nov 1, 2024
10 checks passed
@gray-bot gray-bot mentioned this pull request Nov 1, 2024
@griest024 griest024 deleted the feat/dgeni/align-models branch November 1, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin tools: dgeni @daffodil/tools-dgeni
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Declutter generation for package list assets (package list)
1 participant