feat(design)!: remove the diameter property of loading icon #3341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The diameter property currently takes a number. This means the number is always a fixed value, currently set in pixel.
Fixes: N/A
What is the new behavior?
Remove diameter property completely so that it's up to the outer component to set its width/max-width. The default max width is set to
64px
.Does this PR introduce a breaking change?
BREAKING CHANGE: The
diameter
property has been removed. Awidth
ormax-width
can be updated by adding custom styles.Other information