Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: remove the diameter property of loading icon #3341

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Nov 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The diameter property currently takes a number. This means the number is always a fixed value, currently set in pixel.

Fixes: N/A

What is the new behavior?

Remove diameter property completely so that it's up to the outer component to set its width/max-width. The default max width is set to 64px.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: The diameter property has been removed. A width or max-width can be updated by adding custom styles.

Other information

@xelaint xelaint added the package: design @daffodil/design label Nov 7, 2024
@xelaint xelaint requested a review from damienwebdev November 7, 2024 09:32
@xelaint xelaint requested a review from a team as a code owner November 7, 2024 09:32
@xelaint xelaint force-pushed the loading-icon-update branch from 0854be7 to 50fc856 Compare November 25, 2024 01:43
@xelaint xelaint changed the title feat(design)!: change the diameter property of loading icon to a string instead of number feat(design)!: remove the diameter property of loading icon Nov 26, 2024
@xelaint
Copy link
Member Author

xelaint commented Nov 26, 2024

@damienwebdev removed the diameter property.

Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit f8f9e94 into develop Nov 26, 2024
13 checks passed
@damienwebdev damienwebdev deleted the loading-icon-update branch November 26, 2024 15:58
@gray-bot gray-bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants