Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework documentation pages about implemented rules #86

Closed
jycr opened this issue Mar 27, 2023 · 8 comments
Closed

Rework documentation pages about implemented rules #86

jycr opened this issue Mar 27, 2023 · 8 comments
Assignees
Labels
__PRIO_MEDIUM__ 🗒️ documentation Improvements or additions to documentation

Comments

@jycr
Copy link
Contributor

jycr commented Mar 27, 2023

Pages concerned:

  • docs/rules/web-matrix.md
  • docs/rules/web-rules.md

Needs:

  • Add the rule key on each line that the described rule is implemented
@jycr jycr changed the title Rework documentation pages about rules Rework documentation pages about implemented rules Mar 27, 2023
@dedece35 dedece35 added 🗒️ documentation Improvements or additions to documentation __PRIO_MEDIUM__ 🔰 good first issue Good for newcomers labels Mar 29, 2023
@dedece35 dedece35 self-assigned this Mar 30, 2023
@dedece35
Copy link
Member

PR #88 in progress : waiting for review (@glalloue)

@dedece35 dedece35 added 🔥 in progress 🔥 and removed 🔰 good first issue Good for newcomers labels Mar 30, 2023
@jycr
Copy link
Contributor Author

jycr commented Mar 31, 2023

SonarQuabe has a centralized repository to describe each of its rules, which is independent of the different existing implementations:
https://github.com/SonarSource/rspec

This makes it possible to have a centralized vision of the rules, and their variations according to the programming languages.
This also helps to avoid problems/conflicts in assigning identifiers (keys) for the rules.

This also makes it easier to write descriptions (in asciidoc/markdown).

Perhaps this orientation could become interesting for the future of ecoCode rules?

@dedece35
Copy link
Member

dedece35 commented Apr 1, 2023

hi @jycr
good idea ... maybe to discuss about it in our Slack or during a weekly live meeting to expose more accurately your idea.

@utarwyn
Copy link
Member

utarwyn commented Apr 1, 2023

Hello! I think it's a very good idea to centralize the rules, to have one common knowledge base for the ecoCode project. It will simplify even more the readability of the rules, especially for those that are implemented, to be implemented, etc. 💯

However, I don't think we should copy their structure as it exists in their repository. When reading their README you can see that they have created a lot of processes to maintain the rules, and rightly so. But we don't have the same project size, the goal is not to make the process unnecessarily complex for the community.

@jhertout
Copy link
Contributor

jhertout commented Apr 3, 2023

Hi @jycr , I think it is a good idea too. We tried to do something for eco-mobile but it is not in the sate of https://github.com/SonarSource/rspec. I thing we should discuss how it works and how we can apply this to our project.

@glalloue
Copy link
Contributor

glalloue commented Apr 3, 2023

concerning the original subject to rework those pages :

  • docs/rules/web-matrix.md
  • docs/rules/web-rules.md

Work is done by this PR : #88

rule key on each line is added when it was possible.

Maybe we can create a new issue related to rules centralized repository and close this one.
What is your opinion @dedece35 ?

@dedece35
Copy link
Member

dedece35 commented Apr 3, 2023

@glalloue
I agree with you ... new issue for @jycr idea : #92
(I did a copy-paste of your idea, @jycr)

@dedece35
Copy link
Member

dedece35 commented Apr 3, 2023

correction done with PR #88

@dedece35 dedece35 closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
__PRIO_MEDIUM__ 🗒️ documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants