Rule/erea001 supported version range #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 9, 2023 15:48
…mpose file is invalid because: Service sonar has neither an image nor a build context specified. At least one must be provided."
jhertout
reviewed
Mar 9, 2023
| NodeList rule = doc.getElementsByTagName("rule"); | ||
| assertThat(activeRules).as("Expected number of rules in profile").hasSize(rule.getLength()); | ||
| } catch (ParserConfigurationException | SAXException | IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
What happens if we have this this exception ? The assert l65 is skipped and we have no test failure I think. We must force a failure here.
|
I also add dynamic groovy rules size checking in test file GroovySonarWayProfileTest, reading the rules.xml file and checking the number of node |
if the file is not found in the project, the test will fail showing the FileNotFoundException
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a fix to the dockerFile
Update SupportedVersionRange rule checking minSdk and targetSdk in gradle