Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure all Rules are registered #29

Closed
dedece35 opened this issue Jul 26, 2024 · 0 comments · Fixed by #30
Closed

Add test to ensure all Rules are registered #29

dedece35 opened this issue Jul 26, 2024 · 0 comments · Fixed by #30
Assignees
@dedece35
Labels
🏗️ refactoring refactoring for best practices 🚀 enhancement New feature or request

Comments

@dedece35
Copy link
Member

dedece35 commented Jul 26, 2024 •
edited
Loading

like done in ecocode-java plugin, upgrade tests to avoid using a fixed number of rules during check controls.
to do this, uses reflections to detect how many rule classes are implemented against th number really declared.

see green-code-initiative/creedengo-java#49
and green-code-initiative/creedengo-php#34
@dedece35 dedece35 added 🏗️ refactoring refactoring for best practices 🔥 in progress 🔥 🚀 enhancement New feature or request labels Jul 26, 2024
@dedece35 dedece35 self-assigned this Jul 26, 2024
@dedece35 dedece35 linked a pull request Jul 26, 2024 that will close this issue
Add test to ensure all Rules are registered #30
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dedece35 dedece35

Labels
🏗️ refactoring refactoring for best practices 🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test to ensure all Rules are registered green-code-initiative/creedengo-python
1 participant
@dedece35