Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to Maven Central #210

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Publish to Maven Central #210

merged 2 commits into from
Aug 8, 2023

Conversation

jycr
Copy link
Contributor

@jycr jycr commented Jul 11, 2023

Add required information in pom.xml and GitHub workflow to automate publishing to Maven Central.

Changes required on GitHub account:

  • Add a secret for GPG private key: MAVEN_GPG_PRIVATE_KEY
  • Add a secret for GPG Key passphrase: MAVEN_GPG_PASSPHRASE
  • Add secrets for Central authentication : OSSRH_USERNAME and OSSRH_TOKEN (corresponding to the account declared on https://issues.sonatype.org)

@jycr jycr force-pushed the feature/publish-to-maven-central branch from 12142fb to 4f19b36 Compare July 11, 2023 09:02
@jycr jycr requested review from dedece35, jhertout and glalloue July 12, 2023 09:42
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/publish_to_maven_central.yml Outdated Show resolved Hide resolved
.github/workflows/publish_to_maven_central.yml Outdated Show resolved Hide resolved
@dedece35
Copy link
Member

Hi @jycr

please check and correct buil / test errors above, before all.

@jycr jycr force-pushed the feature/publish-to-maven-central branch from 4f19b36 to 8822f98 Compare July 16, 2023 13:19
@jycr jycr requested a review from utarwyn July 16, 2023 13:22
@jycr jycr force-pushed the feature/publish-to-maven-central branch from 8822f98 to 8405c0d Compare July 16, 2023 13:23
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jycr,

you said in description :

Changes required on GitHub account:

Add a secret for GPG private key: MAVEN_GPG_PRIVATE_KEY
Add a secret for GPG Key passphrase: MAVEN_GPG_PASSPHRASE
Add secrets for Central authentication : OSSRH_USERNAME and OSSRH_TOKEN (corresponding to the account declared on https://issues.sonatype.org/)

Ok for the creation of variables OSSRH_USERNAME and OSSRH_TOKEN. I understand we need them for contacting Sonatype.
But where do you want me to create these variables and with what values ? (in settings of ecoCode repository) ?

Secondly, I don't understand the need of GPG variables ? why are they needed ? for encryption of sent data to Sonatype ?
where do you want me to create these variables and with what values ? (in settings of ecoCode repository) ?

@jycr
Copy link
Contributor Author

jycr commented Jul 21, 2023

where do you want me to create these variables and with what values ? (in settings of ecoCode repository) ?

Yes, in ecoCode repository

I don't understand the need of GPG variables ? why are they needed ? for encryption of sent data to Sonatype ?

GPG variables is needed to create GPG signature of artifacts to deploy as requested in The Central Repository Documentation / Publishing my artifact / GPG Signed Components

You can see those signatures (.asc files) in the manually uploaded 0.0.1 version on Maven Central

where do you want me to create these variables and with what values ? (in settings of ecoCode repository) ?

Yes, in ecoCode repository

@jycr jycr requested a review from dedece35 July 21, 2023 23:47
@dedece35 dedece35 added the 🚀 enhancement New feature or request label Jul 23, 2023
@jycr jycr requested a review from dedece35 July 24, 2023 21:39
@jycr jycr force-pushed the feature/publish-to-maven-central branch from ed482aa to 53bda57 Compare August 5, 2023 14:42
@jycr jycr force-pushed the feature/publish-to-maven-central branch from 53bda57 to c5c7589 Compare August 8, 2023 15:19
@jycr jycr force-pushed the feature/publish-to-maven-central branch from 294f7b7 to cf4784a Compare August 8, 2023 15:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dedece35 dedece35 merged commit 645a183 into main Aug 8, 2023
@dedece35 dedece35 deleted the feature/publish-to-maven-central branch August 8, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants