-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate rule EC4 for Java because not applicable #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I agree with @dedece35, I think we must depreciate the rule in a first time if we want to be rigorous. Since our plugin is public I think it is important for us to try to follow this process even if I understand that it can be frustrating. |
I will deprecate it first, you are right. Let me change this. But I will need #242 in order to do it properly. We can discuss the process around rule deprecation/deletion during the next meeting if you want. |
9fef634
to
2b0d4b0
Compare
In order to have a smoother transition before the rule deletion, I have deprecated it. You can see the result in the SonarQube UI below. It will now be necessary to define how long it remains deprecated, but this will be discussed at the next meeting. I kept the unit test and implementation, to keep it working before everyone turned it off in quality profiles. |
2b0d4b0
to
8ec9e9d
Compare
to discuss in core-team : deprecation if this rule only for java |
8ec9e9d
to
628f246
Compare
628f246
to
3176b02
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
After discussion in #233, we confirmed that the rule "Use global variables" was not applicable to the Java language.
This PR therefore removes it completely from the Java plugin and rules specifications.
I've decided to remove it rather than deprecate it, as it proposes incorrect information that I don't think should be left in the plugin. This way, they should no longer appear in SonarQube analyses, as soon as an instance has been updated.Thanks for the discussion and feedback on this rule. It's how we manage to fine-tune the plugin and come up with the most relevant rules possible.
Resolves #233