Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5 support? #21

Open
prdanelli opened this issue Aug 8, 2018 · 7 comments
Open

Rails 5 support? #21

prdanelli opened this issue Aug 8, 2018 · 7 comments

Comments

@prdanelli
Copy link

Hello,

Firstly, thank you for your work creating this Gem.

I was wondering if you planned on bumping the Rails/Ruby version to support newer versions? At the moment I'm using a clone, but i'd love start using the Gem again.

This is the commit that made it Rails 5 / Ruby 2.5 compatible:

builtbybuffalo@839b1a1

Thank you for your time :)

@prdanelli
Copy link
Author

Hello, bump. Is this project zombieware now?

@prdanelli
Copy link
Author

Just bumping everyone @reinh @bcurren @f3z0 @trobrock

Hey everyone, will the project be updated for ruby 2.5+ ?

@trobrock
Copy link
Contributor

@prwhitehead thanks for the issue. I'm not 100% sure if Green Bits is going to continue to maintain this. Let me find that out. If not, I would love to on my fork.

@prdanelli
Copy link
Author

@trobrock Thank you got getting back to me. Sorry for the bump. I'd just like to move a project off of a temp branch with the Ruby 2.5 fixes, on to something more permanent.

Thank you for your work on the project, its very much appreciated.

@bcurren
Copy link

bcurren commented Feb 28, 2020

@prwhitehead, are you able to send a pull request with the ruby 2.5 changes?

@trobrock
Copy link
Contributor

@prwhitehead just wanted to give you a heads up. I am working with the team at Green Bits to take over some of their Ruby libraries (this one included). I have my fork up to date of this project at trobrock/weighable. Feel free to make a PR there, but I will also try and get the changes you suggested done and tested soon.

@trobrock
Copy link
Contributor

@bcurren you are welcome to close this, I've moved it to trobrock#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants