Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed R8 rules in JAR #652

Closed
kyze8439690 opened this issue Jul 21, 2020 · 5 comments
Closed

Embed R8 rules in JAR #652

kyze8439690 opened this issue Jul 21, 2020 · 5 comments
Assignees
@greenrobot-team
Milestone
3.3.0

Comments

@kyze8439690
Copy link

Link: https://google.github.io/android-gradle-dsl/current/com.android.build.gradle.internal.dsl.BuildType.html#com.android.build.gradle.internal.dsl.BuildType:consumerProguardFiles
@greenrobot-team
Copy link
Collaborator

EventBus is not distributed as an Android library (AAR), so that won't work.

But we could embed them using a meta-inf file similar to objectbox/objectbox-java@92f3cd5

@greenrobot-team greenrobot-team changed the title Use consumerProguardFiles to provide proguard rule in AAR Embed R8 rules in JAR Jul 27, 2020
@greenrobot-team greenrobot-team self-assigned this Jul 27, 2020
@kyze8439690
Copy link
Author

If proguard rule is embeded in META-INF directory, can gradle build system refer to this file?

@greenrobot-team
Copy link
Collaborator

Once we do, yes. However, it's R8 that uses this file, not Gradle.
https://twitter.com/jakewharton/status/1004401938467876865

@qeadsw
Copy link

qeadsw commented Apr 13, 2021

This proposal is necessary because it is in step with The Times. Hope the official adoption update!

@greenrobot-team
Copy link
Collaborator

Resolved as part of #670.

@greenrobot-team greenrobot-team added this to the 3.3.0 milestone Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greenrobot-team greenrobot-team

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
3 participants
@kyze8439690 @greenrobot-team @qeadsw