Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveAdmin pagination doesn't respect config.param_name setting #1371

Closed
rogerkk opened this issue May 31, 2012 · 3 comments · Fixed by #1514
Closed

ActiveAdmin pagination doesn't respect config.param_name setting #1371

rogerkk opened this issue May 31, 2012 · 3 comments · Fixed by #1514

Comments

@rogerkk
Copy link
Contributor

rogerkk commented May 31, 2012

Hi guys, thanks for the great work!

I've set up Kaminari with a different config.param_name ("page" in my native language), but this breaks the pagination in ActiveAdmin as it is still looking for "page" ang not what I've set up in the Kaminari initializer.

Wouldn't it be sweet if ActiveAdmin respected that config variable?

@latortuga
Copy link
Contributor

The issue looks to be here, I think. I bet changing that to test for the Kaminari default parameter instead of hard-coding :page would fix the problem.

@pcreux
Copy link
Contributor

pcreux commented Jun 2, 2012

@latortuga Right!

@rogerkk Feel free to fix this (call Kaminari.config.param_name instead of :page) and make a pull request! :)

@rogerkk
Copy link
Contributor Author

rogerkk commented Jun 2, 2012

I'm bit of a newbie when it comes to RoR, and not quite sure how to set up, fix and test this atm. If you have any pointers, then they are much appreciated. If not, I'll try to figure it out, but not making any promises.. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants