Fixed bug with active_admin_comments #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with no default_namespace or :root default_namespace
gregbell
added a commit
that referenced
this pull request
Oct 13, 2011
Fixed bug with active_admin_comments
|
Thanks Jonathan! Good find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problem with active_admin_comments not working if default_namespace is set to false or :root.
comment_form_url prepends comments_path with the namespace. If it's root, this means you end up with root_comments_path, which won't work.
I added a simple check to see if it's root. If so, it returns comments_path instead.