Fix pagination/blank_slate i18n and add specs #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition a new option :entries_name was added to allow specifying the collections plural. Updated index to use this.
Testing the page_entries_info behaviour. Also removed excess white space.
mattvague
added a commit
that referenced
this pull request
Oct 19, 2011
Fix pagination/blank_slate i18n and add specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses proper model i18n when resolving the collection name and adds a new option :entries_name to specify the plural to be able to pass in the correct plural_resource_name. I added unit tests for the functionality in page_entries_info that should have good coverage.
Also fix blank_slate to use correct plural_resource_name instead of pluralize.