#580 stylesheet registration #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2011 17:16
…ylesheet with ActiveAdmin while providing an options hash as one would normally use in layouts.
…y available options hash for CSS registration
Closed
| ActiveAdmin.register Post | ||
| """ | ||
| When I am on the index page for posts | ||
| Then I should see the css file "some-random-css.css" | ||
| Then I should see the css file "some-random-css.css" of media :print |
There was a problem hiding this comment.
Could you wrap the media parameter between double quotes? It's a convention that we'd like to see in ActiveAdmin. So the step would be:
Then I should see the css file "some-random-css.css" of media "print"
|
No problem, I can make those changes and update the branch sometime this week and let you know once those are in place. |
|
@macfanatic This is a great contribution, thank you very much for this! |
|
Believe this latest commit includes all requested tweaks. |
|
Awesome. I'll get it merged in |
|
Merged in to master! Thanks for the great commits @macfanatic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ActiveAdmin::Stylesheet class that allows user to register a stylesheet with ActiveAdmin while providing an options hash as one would normally use in layouts.
Example: