Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few Rails 3.2 fixes #931

Merged
merged 6 commits into from
Jan 21, 2012
Merged

A few Rails 3.2 fixes #931

merged 6 commits into from
Jan 21, 2012

Conversation

mperham
Copy link
Contributor

@mperham mperham commented Jan 20, 2012

Here's a set of small commits which fix a number of bugs and deprecation warnings which show up in the new Rails 3.2 release.

@mperham
Copy link
Contributor Author

mperham commented Jan 20, 2012

I verified the test suite passes on Rails 3.2 and 3.1.

@mperham
Copy link
Contributor Author

mperham commented Jan 20, 2012

Forgot to mention, there is one bug in thoughtbot/shoulda#173 that breaks two tests with an error about "primary_key_name". Once I patched that bug, the tests pass.

@schneems
Copy link

+1 linking to your fork in my gem file worked to get my server and console started

@mhenrixon
Copy link

+1 also using @mperham 's fork to make it work

@ghost ghost assigned gregbell Jan 21, 2012
@gregbell gregbell merged commit fb515af into activeadmin:master Jan 21, 2012
@tokland
Copy link

tokland commented Jan 24, 2012

At config/environments/development.rb I have to write config.reload_classes_only_on_change = false, if I set it to true then code in app/admin/* is not reloaded and I have to restart the server. Is that normal? Using b5b97e1

@mhenrixon
Copy link

I am seeing the exact same thing with Grape that I am using for our API on
WODstack so I think it has to do with rails not picking up the reload
requests for other stuff than the rails internals. I've tried every single
combination of reloading libs/folders and files so if anyone find a good
workaround for this please tell me :)

@folano
Copy link

folano commented Jan 27, 2012

@mjacobus
Change the Gemfile to:
gem 'activeadmin', :git => 'git://github.com/gregbell/active_admin.git'

then $bundle install

It worked for me.

@mjacobus
Copy link

@folano
Thank you for your help. Didn't work though. That is what I have in my Gemfile. I guess it is something else. The classes should not be cached cause my config is correct
config.cache_classes = false
config.action_controller.perform_caching = false

I don't know what else to do.

=/

Thank you anyway.

@tokland
Copy link

tokland commented Jan 27, 2012

A temporal workaround that works for me till we figure out the real problem:

# config/environments/development.rb`
config.reload_classes_only_on_change = true
config.watchable_dirs[File.join(config.root, "app/admin")] = ["rb"]

http://rubydoc.info/github/rails/rails/master/Rails/Railtie/Configuration#watchable_dirs-instance_method

@mjacobus
Copy link

@tokland

I love you dude! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants