Avoid synchronous loading on client if options.ssr is false #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #345. See description there for more details.
tl;dr: in cases where
ssr: false
is set, this PR fixes the way we render the component on the client to match what the server is doing, avoiding problematic SSR hydration mismatches (https://reactjs.org/docs/react-dom.html#hydrate).Test plan
Updated the SSR example to add a new letter,
G
, which is rendered on the page with bothssr: true
andssr: false
. Without the change applied, the DOM looks like this (incorrect):with the change applied, the DOM now correctly looks like this:
As mentioned in #345, I can't see any existing integration tests for SSR: if I missed some or if you think it's worth adding some, I'm happy to help set that up. Thanks in advance for reviewing!